Change toplo branch#195
Merged
Merged
Conversation
Nyan11
reviewed
Jul 22, 2024
Collaborator
There was a problem hiding this comment.
Current:
If We remove the Bloc and the Toplo dependance. (They are still in Toplo-Serialization and Bloc-Serialization):
If we choose the later, the Bloc-Serialization and the Toplo-Serialization will define the Bloc version and the Toplo version.
The later is less spaghetti but we do not have a direct knowledge of the Bloc and Toplo version
Collaborator
|
@labordep i suggest we merge. What do you think ? |
Member
Author
|
@Nyan11 that's what I want: by default all dependencies manage here sub dependencies and the responsibility is dispatched in differents projects. If a project wants to change default branch it's its reponsibility to do that on top of the baseline. |
Member
Author
|
We can remove Bloc and Toplo dependencies. |
Nyan11
self-requested a review
July 22, 2024 14:48
Nyan11
approved these changes
Jul 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.